Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can switch between Snapshots but not Pedalboards #76

Open
joaorodriguesjr opened this issue Dec 28, 2024 · 6 comments
Open

Can switch between Snapshots but not Pedalboards #76

joaorodriguesjr opened this issue Dec 28, 2024 · 6 comments

Comments

@joaorodriguesjr
Copy link

Is there a reason why MIDI "pedalboard switching" seems to be disabled somewhere?

The logs indicate that pedalboard switching is turned off on startup. Snapshot switching works fine.

Host Logs

PROTOCOL: response 'resp 0'
PROTOCOL: received 'monitor_midi_program' '4' '1'
PROTOCOL: response 'resp 0'
PROTOCOL: received 'monitor_midi_program' '9' '1'
...
PROTOCOL: response 'resp 0'
PROTOCOL: received 'monitor_midi_program' '4' '1'
PROTOCOL: response 'resp 0'
PROTOCOL: received 'monitor_midi_program' '4' '0'

UI Logs

DEBUG:root:[host] popped from queue: monitor_midi_program 4 1
DEBUG:root:[host] sending -> monitor_midi_program 4 1
DEBUG:root:[host] popped from queue: monitor_midi_program 9 1
DEBUG:root:[host] sending -> monitor_midi_program 9 1
...
DEBUG:root:[host] popped from queue: monitor_midi_program 4 1
DEBUG:root:[host] sending -> monitor_midi_program 4 1
...
DEBUG:root:[host] popped from queue: monitor_midi_program 4 0
DEBUG:root:[host] sending -> monitor_midi_program 4 0

Screenshot from 2024-12-28 17-49-55

@joaorodriguesjr
Copy link
Author

Every time the Web GUI is opened monitor_midi_program is set to 0 for the Pedalboard MIDI channel and back to 1 when closed.

So, MIDI "pedalboard switching" works only with the Web GUI closed. Is this the expected behaviour?

@raidolo
Copy link

raidolo commented Jan 6, 2025

@joaorodriguesjr It's expected. It's not enabled in mod-ui, yet. I've asked for this for so long, check this: #14

I had to fix mod-ui by myself and I've created a docker version of the mod software. It's not perfect and has some bugs when switching the pedalboards, but it can be used. Check info here, don't build it, just use the latest Linux image from dockerhub using the run_docker script https://github.com/raidolo/mod-docker

@joaorodriguesjr
Copy link
Author

@raidolo As soon i realized that the Web UI was causing the MIDI switching to be turned off, I just rolled with it.

I’ve just got back to my guitar, so I don’t even have a physical footswitch. I was working on a small program to quickly switch presets using my PC keyboard.

What I’m doing now is using the Web UI to build and update the presets. When I’m just playing the guitar, I keep it closed and use my own switcher.

midi-switcher

@raidolo
Copy link

raidolo commented Jan 6, 2025

What I’m doing now is using the Web UI to build and update the presets. When I’m just playing the guitar, I keep it closed and use my own switcher.

Ok, I got it, but I like to have the UI in foreground, which should be the whole point of MOD Desktop. I'm waiting for a final fix then I'll ditch my docker version... nice to know that when the UI is closed the pedalboard switching works fine. I didn't try that in the past. I could do it using my custom midi pedalboard which has a color display, and keeping the UI closed... but I'm using a mini pc in a metal briefcase with a usb monitor... so again, it would be better to have the UI opened all the time

@joaorodriguesjr
Copy link
Author

Before I realized that keeping the UI closed would work in my case, I scratched my head trying to figure out where in the code this issue was happening to fix it, but I couldn't.

@raidolo
Copy link

raidolo commented Jan 6, 2025

Before I realized that keeping the UI closed would work in my case, I scratched my head trying to figure out where in the code this issue was happening to fix it, but I couldn't.

Check the modifications I've made in my fork to make it works: mod-audio/mod-ui@master...raidolo:mod-ui:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants