Removes redundant re-running of kani process #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
reviewed
May 11, 2023
| @@ -7,7 +7,7 @@ | |||
| "type": "git", | |||
| "url": "https://github.com/model-checking/kani-vscode-extension" | |||
| }, | |||
| "version": "0.0.2", | |||
| "version": "0.0.4", | |||
| @@ -21,7 +21,18 @@ export async function runKaniHarnessInterface(harnessName: string, args?: number | |||
| harnessCommand = `${KaniConstants.CargoKaniExecutableName} ${KaniArguments.harnessFlag} ${harnessName} ${KaniArguments.unwindFlag} ${args}`; | |||
| } | |||
| const kaniOutput = await catchOutput(harnessCommand); | |||
| return kaniOutput; | |||
| if (typeof kaniOutput == 'number') { | |||
There was a problem hiding this comment.
Can be refactored into another function.
| ) { | ||
| return kaniOutput; | ||
| } else { | ||
| return [5, '']; |
| @@ -212,20 +212,25 @@ export class TestCase { | |||
| async run(item: vscode.TestItem, options: vscode.TestRun): Promise<void> { | |||
| const start: number = Date.now(); | |||
| if (this.proof_boolean) { | |||
| const actual: number = await this.evaluate( | |||
| const actualResult: any = await this.evaluate( | |||
There was a problem hiding this comment.
Is this a verification result? What does actual mean here?
| this.file_name, | ||
| this.harness_name, | ||
| this.harness_unwind_value, | ||
| ); | ||
|
|
||
| const actual = actualResult[0]; |
|
Closing this draft PR. While some refactoring is required in the command running module, this is not the way to go about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The extension's process for running Kani runs Kani twice (for cases where there's a failure). Once for getting the overall verification result, and then for getting the output of Kani. Now, the process does not re-run for failed cases and simply returns the output and the result at the same time.
Resolved issues:
Resolves #43
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.