Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include manifest-path when checking if packages are in the workspace #3819

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Include manifest-path when checking if packages are in the workspace #3819

wants to merge 3 commits into from

Conversation

qinheping
Copy link
Contributor

With this PR, we include --manifest-path in to_package_ids function as part of the command.

Resolves #3816

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@qinheping qinheping requested a review from a team as a code owner January 9, 2025 22:15
zhassan-aws
zhassan-aws reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can we add a test?

@qinheping
Copy link
Contributor Author

Thanks. Can we add a test?

Test added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhassan-aws zhassan-aws zhassan-aws left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kani doesn't consider cargo arguments when finding the packages in a workspace
2 participants
@qinheping @zhassan-aws