Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching for generated files #37

Open
dergraaf opened this issue May 5, 2019 · 3 comments
Open

Add caching for generated files #37

dergraaf opened this issue May 5, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@dergraaf
Copy link
Member

dergraaf commented May 5, 2019

Files should not be regenerated if the configuration did not change.

@dergraaf dergraaf added the enhancement New feature or request label May 5, 2019
@salkinium
Copy link
Member

salkinium commented May 5, 2019

I'm not sure how much time this will save tho. For reference, building node tree for lbuild discover for a large modm example takes ~0.7s, generating the the selected modules takes ~1.8s.

Ok, generating the whole library takes ~5s. Good point.

@salkinium
Copy link
Member

This needs to be super robust though. There is nothing worse than to start mistrusting lbuild because it didn't rebuild something.

@dergraaf
Copy link
Member Author

dergraaf commented May 6, 2019

That is true. The solution I had in mind would actually not bring any speed-up (or only if we're IO write limited), but would instead allow to detect local changes by hashing/comparing the output before writing it to the output file. This would solve #19 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants