Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Tiny change in https://docs.modular.com/max/tutorials/magic #236

Open
marionegroponzi opened this issue Oct 9, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@marionegroponzi
Copy link

Where is the problem?

https://docs.modular.com/max/tutorials/magic

What can we do better?

The page
https://docs.modular.com/max/tutorials/magic#step-5-use-a-nested-package
suggests running magic run bash local/zero

but that returns "local/zero: local/zero: cannot execute binary file"

The command should be changed to magic run bash -c local/zero.

Anything else?

You're awesome!

@marionegroponzi marionegroponzi added the documentation Improvements or additions to documentation label Oct 9, 2024
@marionegroponzi
Copy link
Author

Also, I believe the build command magic run mojo build local/zero.mojo cannot (?) work. It should instead be

cd local
magic run mojo build zero.mojo

@ehsanmok ehsanmok self-assigned this Oct 17, 2024
@ehsanmok
Copy link
Member

Thanks! good catch. Will fix in the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants