From 8c612028c5fc1ebbfbeb8daba48e8d641312ce9c Mon Sep 17 00:00:00 2001 From: Jairo Llopis Date: Wed, 31 Jan 2024 10:02:02 +0000 Subject: [PATCH] [FIX] l10n_fr_siret[_lookup]: remove wrong dependency Odoo 16 depends on both requests and python-stdnum, so there's no need to specify those dependencies. Besides, [python-stdnum is pinned to 1.16][1]. Thus, when applying https://github.com/OCA/oca-ci/pull/66 locally, the constraint failed. OCA addons should work with the dependencies pinned upstream. [1]: https://github.com/odoo/odoo/blob/fe4d8e8014e50d4335e0a8b052b5098f3a79bcec/requirements.txt#L48 @moduon MT-4520 --- l10n_fr_siret/README.rst | 7 +++- l10n_fr_siret/__manifest__.py | 2 +- l10n_fr_siret/readme/INSTALL.rst | 1 + l10n_fr_siret/static/description/index.html | 2 +- l10n_fr_siret_lookup/README.rst | 7 +++- l10n_fr_siret_lookup/__manifest__.py | 2 +- l10n_fr_siret_lookup/readme/INSTALL.rst | 1 + .../static/description/index.html | 35 +++++++++++-------- requirements.txt | 1 - 9 files changed, 37 insertions(+), 21 deletions(-) create mode 100644 l10n_fr_siret/readme/INSTALL.rst create mode 100644 l10n_fr_siret_lookup/readme/INSTALL.rst diff --git a/l10n_fr_siret/README.rst b/l10n_fr_siret/README.rst index ce44e24ad3..f048f60f87 100644 --- a/l10n_fr_siret/README.rst +++ b/l10n_fr_siret/README.rst @@ -7,7 +7,7 @@ French company identity numbers SIRET/SIREN/NIC !! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! - !! source digest: sha256:1bef5e4cd64376e2cfc57493b304967a8f2ee67311cee1bf2daaca919a390f29 + !! source digest: sha256:ea67eff242155510a0475c4cde9e7cb9b442becd6900f867e9e22be734254c13 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! .. |badge1| image:: https://img.shields.io/badge/maturity-Mature-brightgreen.png @@ -43,6 +43,11 @@ The **l10n_fr** module from the official addons adds a *SIRET* field on partners .. contents:: :local: +Installation +============ + +It's recommended to install ``python-stdnum>=1.18`` for SIRET support. + Usage ===== diff --git a/l10n_fr_siret/__manifest__.py b/l10n_fr_siret/__manifest__.py index 0fb8348850..de9a3a537a 100644 --- a/l10n_fr_siret/__manifest__.py +++ b/l10n_fr_siret/__manifest__.py @@ -12,7 +12,7 @@ "website": "https://github.com/OCA/l10n-france", "license": "AGPL-3", "depends": ["l10n_fr", "base_view_inheritance_extension"], - "external_dependencies": {"python": ["python-stdnum>=1.18"]}, + "external_dependencies": {"python": ["python-stdnum"]}, "data": [ "views/res_partner.xml", "views/res_company.xml", diff --git a/l10n_fr_siret/readme/INSTALL.rst b/l10n_fr_siret/readme/INSTALL.rst new file mode 100644 index 0000000000..4d53f118c2 --- /dev/null +++ b/l10n_fr_siret/readme/INSTALL.rst @@ -0,0 +1 @@ +It's recommended to install ``python-stdnum>=1.18`` for SIRET support. diff --git a/l10n_fr_siret/static/description/index.html b/l10n_fr_siret/static/description/index.html index 92e8e77ee4..2f93aa791d 100644 --- a/l10n_fr_siret/static/description/index.html +++ b/l10n_fr_siret/static/description/index.html @@ -367,7 +367,7 @@

French company identity numbers SIRET/SIREN/NIC

!! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -!! source digest: sha256:1bef5e4cd64376e2cfc57493b304967a8f2ee67311cee1bf2daaca919a390f29 +!! source digest: sha256:4fe7ec355c01945f41dfe5012dccac1eaf7047463b803ff24e9cc30b8e42a5e4 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->

Mature License: AGPL-3 OCA/l10n-france Translate me on Weblate Try me on Runboat

The l10n_fr module from the official addons adds a SIRET field on partners, but it doesn’t verify its validity. This module l10n_fr_siret adds several features:

diff --git a/l10n_fr_siret_lookup/README.rst b/l10n_fr_siret_lookup/README.rst index a0312b3447..4e7c154281 100644 --- a/l10n_fr_siret_lookup/README.rst +++ b/l10n_fr_siret_lookup/README.rst @@ -7,7 +7,7 @@ SIRET Lookup !! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! - !! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd + !! source digest: sha256:ac452255edc06fcf3217f59520707f90747aa0c82f8f5b4d4bf2fddc31fc1dfb !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png @@ -51,6 +51,11 @@ In the 2 scenarios, it will update the following fields: .. contents:: :local: +Installation +============ + +It's recommended to install ``python-stdnum>=1.18`` for SIRET support. + Usage ===== diff --git a/l10n_fr_siret_lookup/__manifest__.py b/l10n_fr_siret_lookup/__manifest__.py index b6e76d9967..be504afc6e 100644 --- a/l10n_fr_siret_lookup/__manifest__.py +++ b/l10n_fr_siret_lookup/__manifest__.py @@ -14,7 +14,7 @@ "depends": [ "l10n_fr_siret", ], - "external_dependencies": {"python": ["requests", "python-stdnum>=1.18"]}, + "external_dependencies": {"python": ["requests", "python-stdnum"]}, "data": [ "wizard/fr_siret_lookup_view.xml", "views/res_partner.xml", diff --git a/l10n_fr_siret_lookup/readme/INSTALL.rst b/l10n_fr_siret_lookup/readme/INSTALL.rst new file mode 100644 index 0000000000..4d53f118c2 --- /dev/null +++ b/l10n_fr_siret_lookup/readme/INSTALL.rst @@ -0,0 +1 @@ +It's recommended to install ``python-stdnum>=1.18`` for SIRET support. diff --git a/l10n_fr_siret_lookup/static/description/index.html b/l10n_fr_siret_lookup/static/description/index.html index 9f33ea1b6d..40b742498d 100644 --- a/l10n_fr_siret_lookup/static/description/index.html +++ b/l10n_fr_siret_lookup/static/description/index.html @@ -367,7 +367,7 @@

SIRET Lookup

!! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -!! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd +!! source digest: sha256:ac452255edc06fcf3217f59520707f90747aa0c82f8f5b4d4bf2fddc31fc1dfb !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->

Beta License: AGPL-3 OCA/l10n-france Translate me on Weblate Try me on Runboat

This modules updates partner fields via the SIRENE database <https://data.opendatasoft.com>. It uses the dataset economicref-france-sirene-v3 of opendatasoft <https://public.opendatasoft.com/explore/dataset/economicref-france-sirene-v3/information/>. It computes a theorical VAT number from the SIREN and then checks the validity of the VAT number on VIES (if invalid, the VAT number is discarded).

@@ -390,25 +390,30 @@

SIRET Lookup

Table of contents

+
+

Installation

+

It’s recommended to install python-stdnum>=1.18 for SIRET support.

+
-

Usage

+

Usage

To update an existing parter, go to the partner form view and click on Action > SIREN Lookup.

By default, the search field is filled with Company name. To get more accurate results, you may want to add the City name where the company is registered. Then click on Lookup.

A list of company is displayed. You may want to click on one in order to see corresponding information or directly selecting company from tree view. Once a company is selected, the partner information is updated and a message is logged in the chatter.

-

Bug Tracker

+

Bug Tracker

Bugs are tracked on GitHub Issues. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us to smash it by providing a detailed and welcomed @@ -416,16 +421,16 @@

Bug Tracker

Do not contact contributors directly about support or help with technical issues.

-

Credits

+

Credits

-

Authors

+

Authors

  • Le Filament
  • Akretion
-

Contributors

+

Contributors

-

Other credits

+

Other credits

The development of this module has been financially supported by:

  • Le Filament
-

Maintainers

+

Maintainers

This module is maintained by the OCA.

Odoo Community Association

OCA, or the Odoo Community Association, is a nonprofit organization whose diff --git a/requirements.txt b/requirements.txt index 9286606864..39f8b30231 100644 --- a/requirements.txt +++ b/requirements.txt @@ -2,7 +2,6 @@ pgpy pypdf>=3.1.0 python-stdnum -python-stdnum>=1.18 requests requests_oauthlib unicodecsv