Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tag" parameter to ItemList macro #1772

Merged
merged 11 commits into from
Oct 5, 2024
Merged

Conversation

oSquat
Copy link
Contributor

@oSquat oSquat commented Oct 3, 2024

The inverse of "skiptag", allow for a "tag" parameter so that ItemList() only displays items that have been tagged accordingly.

<<ItemList(tag="foo")>>

@oSquat
Copy link
Contributor Author

oSquat commented Oct 3, 2024

This looks like a linter picked some subtle formatting disagreements. If there's something I can do to facilitate the process please offer guidance.

@RogerHaase
Copy link
Member

Thanks for helping.

You must push updates to fix the styling requirements. I think the checks will automatically rerun with every update you make.

@oSquat
Copy link
Contributor Author

oSquat commented Oct 3, 2024

Did that do it? All I did was synchronize my fork preparing to make the prescribed fixes. Thank you for your assistance, I've never experienced this workflow before.

@UlrichB22
Copy link
Collaborator

There is a blank / space character at the end of line 432 in docs/user/creolewiki.rst.
This may be the reason for the failing check. Please try to add a commit to the PR without this blank.

@UlrichB22
Copy link
Collaborator

@oSquat, Please also consider to add the pre-commit hook as described in #1672.

@oSquat
Copy link
Contributor Author

oSquat commented Oct 3, 2024

I hope that's it. @UrlrichB22, thanks for pointing out the issue and I'll have to work on getting my running copy of Moin synchronized to my fork. I made & tested these changes on an installation that's a little outdated and then edited them into a fork through the github UI which isn't a great experience.

@RogerHaase RogerHaase merged commit 722805a into moinwiki:master Oct 5, 2024
6 checks passed
@RogerHaase
Copy link
Member

Thanks for helping. In the future, it is best practice to create a branch for an update rather than making changes directly to master.

@oSquat
Copy link
Contributor Author

oSquat commented Oct 5, 2024

Thanks for your patience and helping me get this through! I'll get a real dev instance setup and branch in the future. I can't imagine it could go less smoothy than this.

@UlrichB22
Copy link
Collaborator

We appreciate your support. You can find more information about the development of moin 2.0 at https://moin-20.readthedocs.io/en/latest/devel/development.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants