feat: Added retry logic to remote api request #760
Closed
+537
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
6 times, most recently
from
3ee81e6
to
4ed8d18
Compare
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
4 times, most recently
from
0bc0ee5
to
bcc4b92
Compare
zhelyabuzhsky
suggested changes
Jul 6, 2022
dmitryanchikov
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
2 times, most recently
from
c694629
to
a326352
Compare
kissken
force-pushed
the
feature/graphite-unavailability-retriable-calls
branch
from
a326352
to
19f04a9
Compare
kissken
reviewed
Aug 24, 2022
| return body, true, nil | ||
| } | ||
|
|
||
| func isRemoteUnavailableStatusCode(statusCode int) bool { |
There was a problem hiding this comment.
теста похоже нет, проверить это надо будет
|
Refactored and implemented in #1085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
ErrRemoteUnavailable. This error is supposed to be used for cases when Remote API is unavailable, e.g. repetitively returns following errors: 401, 502, 503, 504, transport errors, timeoutsRemotesection in checker, api and notifier configs:json: retry_seconds- defines time intervals in seconds for retry calls for errors above, ex.:'1 10 30','1 1json: health_check_timeout- defines timeout for calls for health check, ex.:5sjson: health_check_retry_secondsdefines time intervals in seconds for health check retry calls, ex.:5 5makeRequestWithRetriesis added to perform calls with retries in case of getting errors from the list above. This method is applied in both health check call and fetching trigger metrics call.Future work
There will be follow-up PR for including logic of handling of
ErrRemoteUnavailableerror in trigger check processing and PR for adding new metric for monitoring of graphite unavailability