Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojaloop chart does not support ingress 0.22.* or later #802

Closed
1 of 3 tasks
mdebarros opened this issue Jun 10, 2019 · 4 comments
Closed
1 of 3 tasks

Mojaloop chart does not support ingress 0.22.* or later #802

mdebarros opened this issue Jun 10, 2019 · 4 comments
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service good first issue Good for newcomers infra-bug An infrastructure issue or bug such as in helm charts or documentation oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Milestone

Comments

@mdebarros
Copy link
Member

mdebarros commented Jun 10, 2019

Summary:
Mojaloop chart does not support ingress 0.22.* or later due to the rewrite rules no longer being backwards compatible.

See the following issue for more information: mojaloop/helm#196

Severity:
Medium

Priority:
Medium

Expected Behavior

  • Ingress's should be configured with the new annotations.
  • Value files to be updated to include both annotations but include comments for users to understand why and where one would choose the specific annotations depending on the version of ingress being used.
  • Add an FAQ item to describe the issue and fix dependant on using which version of ingress (e.g. later than or including v0.22, and version earlier than 0.22)

Steps to Reproduce

Deploy an existing version (v6.3.1 or earlier) of Helm chart to a K8s environment that contains Nginx Ingress controller with version 0.22 or later.

Specifications

  • Component (if known):
  • Version: v6.3.1 or earlier
  • Platform: Helm
  • Subsystem:
  • Type of testing: manual
  • Bug found/raised by: @mdebarros (on behalf of community)

Notes:

  • Severity when opened: Medium
  • Priority when opened: Medium
@mdebarros mdebarros added the bug label Jun 10, 2019
@mdebarros
Copy link
Member Author

mdebarros commented Jun 10, 2019

Documentation Pull request for FAQ --> mojaloop/documentation#69

@lewisdaly lewisdaly added the good first issue Good for newcomers label Feb 10, 2020
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Feb 8, 2021
@elnyry-sam-k elnyry-sam-k added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Feb 15, 2021
@elnyry-sam-k
Copy link
Member

@mdebarros - can you please review if we close this now?

@elnyry-sam-k elnyry-sam-k added infra-bug An infrastructure issue or bug such as in helm charts or documentation bug Something isn't working or it has wrong behavior on a Mojaloop Core service and removed bug Something isn't working or it has wrong behavior on a Mojaloop Core service labels Jun 3, 2021
@mdebarros
Copy link
Member Author

Closing this as it's no longer an issue.

The newer versions of the NGINX Ingress Controllers handle this more elegantly.

@elnyry-sam-k
Copy link
Member

Thanks @mdebarros

@elnyry-sam-k elnyry-sam-k added this to the Sprint 14.3 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service good first issue Good for newcomers infra-bug An infrastructure issue or bug such as in helm charts or documentation oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Development

No branches or pull requests

4 participants