Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arisa doesn't expect helper message variables to contain other variables #282

Closed
violine1101 opened this issue May 23, 2020 · 1 comment · Fixed by #285
Closed

Arisa doesn't expect helper message variables to contain other variables #282

violine1101 opened this issue May 23, 2020 · 1 comment · Fixed by #285
Assignees
Labels
enhancement New feature or request

Comments

@violine1101
Copy link
Member

The Problem

If a helper message variable contains another variable, Arisa might not resolve it correctly. This is currently not an issue yet, but the proposed change in mojira/helper-messages#62 would break Arisa. If that PR is merged without Arisa being adjusted, this would turn into a bug.

Expected behavior

Arisa should be able to resolve all variables inside of variables up to a certain point, so that variables can include other variables, but only up to a certain limit (so that Arisa doesn't get stuck in an infinite loop). Here's an example of how I did it in JavaScript: mojira/helper-messages@0c44006#diff-36f8d737c0d72482b317e9b95c615dc2

@violine1101 violine1101 added the enhancement New feature or request label May 23, 2020
@violine1101 violine1101 self-assigned this May 23, 2020
@urielsalis
Copy link
Member

ideally you add the ones you are using into the test, and the test checks that they exist :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants