Disable speedtest on domains with 1 IP

[chmichael]

Hello,
Currently Smartdns is speedtesting websites with 1 IP which it's redundant wasting cpu cycles.
It should only speedtest if the domain has 2 or more IPs to find the fastest one.

Also it tests the same ip twice which i think it's redundant too:
2024-09-19 15:44:38.897:DEBUG:smartdns::dns_mw_ns:519: Speed test api.restream.io. TCP:443 ping 104.18.43.172 elapsed 7.8949ms
2024-09-19 15:44:38.897:DEBUG:smartdns::dns_mw_ns:519: Speed test api.restream.io. TCP:443 ping 104.18.43.172 elapsed 8.0792ms
2024-09-19 15:44:38.914:DEBUG:smartdns::dns_mw_ns:519: Speed test api.restream.io. TCP:443 ping 172.64.144.84 elapsed 22.7931ms

Thank you

[mokeyish]

It seems like this is what you said.

smartdns-rs/src/dns_mw_ns.rs

Lines 266 to 267 in 188fca4

	if ip_addrs.len() == 1 {
	return Ok(lookup);

[chmichael]

Yes, but it doesn't work ? eg.
https://dnschecker.org/domain-ip-lookup.php?query=pubsub.bestprice.gr&dns=google
https://www.nslookup.io/domains/pubsub.bestprice.gr/webservers/

pubsub.bestprice.gr has 1 ip only but smartdns will speed check the ip according to debug log.

2024-09-20 13:25:02.667:DEBUG:smartdns::dns_mw_ns:97: query name: pubsub.bestprice.gr. type: A via [Group: default]
2024-09-20 13:25:02.724:DEBUG:smartdns::dns_mw_ns:519: Speed test pubsub.bestprice.gr. TCP:443 ping 62.103.124.55 elapsed 13.6502ms
2024-09-20 13:25:02.724:DEBUG:smartdns::dns_mw_cache:315: Domain prefetch check will be performed in 29.8257758s.
2024-09-20 13:25:02.754:DEBUG:smartdns::dns_mw_ns:519: Speed test pubsub.bestprice.gr. TCP:443 ping 62.103.124.55 elapsed 15.1474ms

btw, it is speedchecking twice instead of once.
maybe it adding the same IP twice on the list instead of once ?

[chmichael]

Looking at the source the function you describe is in response-mode fastest-ping where i use "response-mode fastest-ip"

[chmichael]

Changed to "response-mode fastest-ping" and it doesn't add duplicate IPs to speed check so the problem with with "response-mode fastest-ip" and maybe fastest-response ?