Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train_data_creator: Better handling of duplicates. #10

Open
svandenhoek opened this issue Jun 28, 2022 · 0 comments
Open

train_data_creator: Better handling of duplicates. #10

svandenhoek opened this issue Jun 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@svandenhoek
Copy link
Contributor

In case a duplicate is found (identical '#CHROM', 'POS', 'REF', 'ALT', 'gene', 'class'), the current approach simply removes any duplicates after the first. This could mean a duplicate which would yield a higher review score (=a higher weight for training) is removed.

A better approach would be to use ensure the highest review score is kept among all sources so that high quality data is treated as such.

@svandenhoek svandenhoek added the enhancement New feature or request label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant