fix: make sure single select scales with content #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
======================================
Coverage 95.1% 95.1%
======================================
Files 21 21
Lines 592 592
Branches 58 58
======================================
Hits 563 563
Misses 24 24
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
fdlk
suggested changes
Apr 29, 2021
| <v-select v-model="localValue" | ||
| class="form-control" |
There was a problem hiding this comment.
That has nasty side-effects:
versus
|
See select2/select2#5964, they went for ellipsis to make the option smaller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: i added some large texts to test for this problem
fixes: #356
Checklist