Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEDGENCUI possible future edge case handling #20

Closed
joeflack4 opened this issue Apr 4, 2024 · 2 comments
Closed

MEDGENCUI possible future edge case handling #20

joeflack4 opened this issue Apr 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@joeflack4
Copy link
Contributor

joeflack4 commented Apr 4, 2024

Regarding contingent MEDGENCUI preservation

Options discussed:
a. Test that fails if any MEDGENCUI appears
b. Let them slip in with the rest of the UMLS / MEDGEN.
c. Filter them out. Write them to a separate file. Or log to a file.
d. A GH action that reviews the release and detects if MEDGENCUI and throw warning.

Edit: This only applies to the Mondo robot template, not for the HPO mappings work: #18.

@joeflack4 joeflack4 changed the title MEDGENCUI follow-ups MEDGENCUI possible future edge case handling Apr 4, 2024
@joeflack4 joeflack4 self-assigned this Apr 4, 2024
@joeflack4
Copy link
Contributor Author

joeflack4 commented Apr 4, 2024

@twhetzel We discussed this at meeting today. But I also saw another comment from Nico in another PR. It looks like both you and Nico concur in the importance of handling this.

I'm going to go with option (c). And it will not take me long. So I will do it now

Edit: Actually went with an alternative to (c). Added a parameter with default to True to filter them out, and just filtered them out.

@joeflack4 joeflack4 added the bug Something isn't working label Apr 4, 2024
@joeflack4
Copy link
Contributor Author

Addressed by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant