Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MedGen build error #23

Closed
joeflack4 opened this issue Apr 15, 2024 · 1 comment · Fixed by #24
Closed

MedGen build error #23

joeflack4 opened this issue Apr 15, 2024 · 1 comment · Fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@joeflack4
Copy link
Contributor

Overview

This is a new error following #18 being merged. I think what happened is that I ran the action successfully, made some changes, and then forgot to check if the action ran successfully again.

I think the problem has to do with the sssom-py version being different between my local environment and the action's.

Error information

ImportError: cannot import name 'MappingSetDataFrame' from 'sssom'

Log

@joeflack4 joeflack4 self-assigned this Apr 15, 2024
@joeflack4 joeflack4 added the bug Something isn't working label Apr 15, 2024
@joeflack4
Copy link
Contributor Author

joeflack4 commented Apr 18, 2024

I thought I remembered Nico and me commenting on this. Nico suggested that the issue was that I needed to import from sssom.utils. I said that made sense, but I showed him __init__.py, which imports MappingSetDataFrame, so importing from sssom should also work. But I'll try the suggestion.

If that doesn't work, perhaps there's a difference between the sssom-py version in my local environment and the one in the GH action, even though the version in my pip freeze is the same as what's shown in requirements.txt.

@joeflack4 joeflack4 linked a pull request Apr 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant