Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Included" symbols: Decide what to do #140

Open
Tracked by #118
joeflack4 opened this issue Sep 14, 2024 · 3 comments
Open
Tracked by #118

"Included" symbols: Decide what to do #140

joeflack4 opened this issue Sep 14, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request omim

Comments

@joeflack4
Copy link
Contributor

joeflack4 commented Sep 14, 2024

Background

Originally in #118 we were going to add these as synonyms. However, we realized that we are specifically not adding "included" titles and instead marking them as mondo#omim_included. We are currently thinking about what to do, and we may end up treating symbols in the same way.

Choices:
a. oio:exactSynonym
b. oio:relatedSynonym
c. oio:closeSynonym
d. mondo#omim_included

I think 'd' for now. If we choose to use a synonym type, then we should also do so for included titles as well. If we were to pick a synonynm type for these, I think would be 'related' or 'close'.

Related

@joeflack4
Copy link
Contributor Author

joeflack4 commented Sep 23, 2024

For now, as of this PR, I'm adding as mondo#omim_included:

@twhetzel
Copy link
Contributor

Can you add some examples of what the original data looks like and what it does (or will) look like when it is processed?

@joeflack4
Copy link
Contributor Author

joeflack4 commented Sep 23, 2024

Sure. Maybe this is sufficient, but let me know if you're looking for a different kind of example:

OMIM:113600 a owl:Class ;
    rdfs:label "branchial cleft anomalies" ;
    MONDONS:omim_included "branchial cysts" ;
    oboInOwl:hasExactSynonym "branchial cleft anomalies" ;
    rdfs:comment "This term has one or more labels that end with ', INCLUDED'." .

This is an example of an existing class with MONDONS:omim_included on an included title.

Hypothetically, if this class also had an included symbol "BC", then it would look like this:

OMIM:113600 a owl:Class ;
    rdfs:label "branchial cleft anomalies" ;
    MONDONS:omim_included "branchial cysts" ;
    oboInOwl:hasExactSynonym "branchial cleft anomalies" ;
    MONDONS:omim_included "BC" ;
    rdfs:comment "This term has one or more labels that end with ', INCLUDED'." .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request omim
Projects
None yet
Development

No branches or pull requests

2 participants