[wallet] no stdout flush on wallet creation

[tankf33der]

versions: - 0.18.3.3 and 0.18.3.4

I can repeat this ONLY on Alpine Linux 3.20, 3.21 (musl!).

Manjaro (ArchLinux) is OK!!!

https://asciinema.org/a/50bn1StLcSCY90zmBJsI0QT1V

No output for "Confirm password:" and it is tricky to complete a wallet creation wizard.

diff --git a/src/common/password.cpp b/src/common/password.cpp
index e6dff95ea..c0edf7a78 100644
--- a/src/common/password.cpp
+++ b/src/common/password.cpp
@@ -185,7 +185,7 @@ namespace
         return false;
       if (verify)
       {
-        std::cout << "Confirm password: ";
+        std::cout << "Confirm password: " << std::flush;
         if (!read_from_tty(pass2, hide_input))
           return false;
         if(pass1!=pass2)

[tankf33der]

Patched version works on Alpine now.

[selsta]

Solved in #9656