You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Monero Project should consider editing the usage of "white" and "gray" in the code base.
Primarily, the usage of "white" and "gray" are confusing and do not thoroughly communicate intent.
Additionally, "gray" is very confusing without more context and the spelling is only popular in American English.
I particularly think "gray" is the most confusing wording across the project, because without further research and understanding of the project, one could easily consider "gray" peers to be ones identified as potentially dangerous but not yet proven banned nodes.
As some initial suggestions I believe the project should move towards using the below naming conventions.
"online" for "white"
"offline" for "gray"
"banned" for "banned" , already implemented and used
"active" for "white"
"inactive" for "gray"
"banned" for "banned" , already implemented and used
Large scale considerations:
Massive breaking changes to the RPC Json API
Invalidates a ton of historical information, guides, and discussions
The text was updated successfully, but these errors were encountered:
I can understand the endeavor but your suggestions do not make sense.
Gray means that monerod received this node from another node address book, and therefore we haven't established contact with it before (if successful it get added to the white address book, if not it means that it get banned).
A gray peer is always offline per definition, but a white peer can be offline as well. Therefore it do not make sense to map active or online to an offline white peer.
The Monero Project should consider editing the usage of "white" and "gray" in the code base.
Primarily, the usage of "white" and "gray" are confusing and do not thoroughly communicate intent.
Additionally, "gray" is very confusing without more context and the spelling is only popular in American English.
I particularly think "gray" is the most confusing wording across the project, because without further research and understanding of the project, one could easily consider "gray" peers to be ones identified as potentially dangerous but not yet proven banned nodes.
As some initial suggestions I believe the project should move towards using the below naming conventions.
Large scale considerations:
The text was updated successfully, but these errors were encountered: