Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] White and Gray List is confusing #9696

Open
ohchase opened this issue Jan 12, 2025 · 1 comment
Open

[Discussion] White and Gray List is confusing #9696

ohchase opened this issue Jan 12, 2025 · 1 comment

Comments

@ohchase
Copy link

ohchase commented Jan 12, 2025

The Monero Project should consider editing the usage of "white" and "gray" in the code base.

Primarily, the usage of "white" and "gray" are confusing and do not thoroughly communicate intent.
Additionally, "gray" is very confusing without more context and the spelling is only popular in American English.
I particularly think "gray" is the most confusing wording across the project, because without further research and understanding of the project, one could easily consider "gray" peers to be ones identified as potentially dangerous but not yet proven banned nodes.

As some initial suggestions I believe the project should move towards using the below naming conventions.

  1. "online" for "white"
  2. "offline" for "gray"
  3. "banned" for "banned" , already implemented and used

  1. "active" for "white"
  2. "inactive" for "gray"
  3. "banned" for "banned" , already implemented and used

Large scale considerations:

  • Massive breaking changes to the RPC Json API
  • Invalidates a ton of historical information, guides, and discussions
@SyntheticBird45
Copy link

SyntheticBird45 commented Jan 12, 2025

I can understand the endeavor but your suggestions do not make sense.

Gray means that monerod received this node from another node address book, and therefore we haven't established contact with it before (if successful it get added to the white address book, if not it means that it get banned).

A gray peer is always offline per definition, but a white peer can be offline as well. Therefore it do not make sense to map active or online to an offline white peer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants