Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over-large message element crashes engine. #30

Open
Dannington opened this issue Dec 13, 2016 · 1 comment
Open

Over-large message element crashes engine. #30

Dannington opened this issue Dec 13, 2016 · 1 comment

Comments

@Dannington
Copy link

Due to the limited maximum size of the variable type (FNAME I think), if a message element is received which is larger than 1024 chars the engine crashes.

Ultimately we should think about changing the type for this message element type, but in the short term we should think about handling the error more gracefully.

@monsieurgustav
Copy link
Owner

I pushed the support for OSC blobs.
You should probably use them for use cases where long strings are needed.

It does not fix this issue though:

  • long OSC strings are not handled correctly (a fix would break compatibility with previous version)
  • it still crashes (a fix needs a strlen call which is "expensive")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants