Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to set a channel name that's too long #164

Open
danpalmer opened this issue Oct 9, 2019 · 0 comments
Open

Possible to set a channel name that's too long #164

danpalmer opened this issue Oct 9, 2019 · 0 comments

Comments

@danpalmer
Copy link
Contributor

I believe it's currently possible to set a channel name with rename that is too long to fit in the database table.

Recommendations of fixes:

  1. Convert to TextField, on Postgres at least there's essentially no performance benefit of using a CharField with a cap over a TextField if you don't want to cap the column size.
  2. Save to the database before making the Slack API calls. This way if the database save fails, Slack isn't modified, but if the API calls fail the database changes will roll back anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant