Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive option #30

Open
mirceaman opened this issue May 24, 2023 · 2 comments
Open

Case sensitive option #30

mirceaman opened this issue May 24, 2023 · 2 comments

Comments

@mirceaman
Copy link

Hello,

We've been using the plugin for a while without issues. Recently, we've had a problem with emails being case-sensitive. If a user pastes email addresses in the plugin it now checks for lower case vs upper case which wasn't the behaviour in the past. Anything changed? Is there a way to revert back?

Best regards,

@danmarsden
Copy link

@abias - I think there are 2 ways to approach this.

  1. delete the custom "local_bulkenrol_get_user()" function and just use the core get_complete_user_data() function instead (which already does the case sensitivity stuff)
    The main differences are that this function won't return deleted users in the response, and it provides a simpler "user not found" error instead of the 3 different errors you provide in your custom function (user not found, more than one user found, error getting user)

  2. We modify the local_bulk_enrol_get_user to do a case insensitive search.

Looking at the code - I lean towards option 1 myself - I'll see if we can send a PR through for you to review using that method.

thanks!

@sumaiyamannan
Copy link

Hi @danmarsden
I have the PR for it here #31
Regards,
Sumaiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants