Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosely couple to Block Number Provider #26

Open
JoshOrndorff opened this issue Jun 28, 2021 · 0 comments
Open

Loosely couple to Block Number Provider #26

JoshOrndorff opened this issue Jun 28, 2021 · 0 comments

Comments

@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Jun 28, 2021

Currently this pallet is tightly coupled to cumulus-pallet-parachain-system for purposes of reading the relay chain block number.

In paritytech/cumulus#515 the parachain system pallet began exposing the relay chain block number through a trait which means this pallet can be abstracted over the BlockNumberProvider.

This has two concrete positive effects:

  1. Other chains can use this pallet unmodified even if they want to use the parachain block number for the vesting schedule.
  2. Parachain system is removed from the dependency graph (and replaced with an easier-to-mock BlockNumberProvider in the tests).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant