-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double::op_mod
on Wasm backend produce JS-inconsistent result when the divisor is in subnormal range
#1303
Comments
Double::op_mod
produce inconsistency result when the divisor is in subnormal rangeDouble::op_mod
on Wasm{,GC} backend produce JS-inconsistent result when the divisor is in subnormal range
Double::op_mod
on Wasm{,GC} backend produce JS-inconsistent result when the divisor is in subnormal rangeDouble::op_mod
on Wasm backend produce JS-inconsistent result when the divisor is in subnormal range
Actually, this error is acceptable for numerical algorithms... but for platformity, algorithms do need to be unified, and the priority may not be as high? |
Hi everyone, I have just verified (from the discussion) that rust-wasm is using libm to standardize their math intrinsics, and their implementation is right ( IMO it's a bit more than just platformity, as many programming languages are using libm as their math library. We can refer to the libm to check the implementation of other math intrinsics too. I'm going to open a PR to fix the current |
@liuly0322 Sounds good, make sure to update NOTICE to include license from libm (and possibly from musl) as well. |
5e-324 % 5e-324
0
-2.1219957905e-314
0.5 % 1.5e-323
1e-323
-3.5837322939398236e-299
The text was updated successfully, but these errors were encountered: