Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] use lockfiles for moon/proto toolchains #1161

Closed
prabirshrestha opened this issue Nov 1, 2023 · 2 comments
Closed

[feature] use lockfiles for moon/proto toolchains #1161

prabirshrestha opened this issue Nov 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@prabirshrestha
Copy link

All package mangers supports lockfile for reproducible builds and security with checksum. Is it possible for moon to support the same such that it is guaranteed that a specific version mentioned in the lockfile is always installed for plugins. Since moon is promoting external unofficial plugins I'm also worried about security where someone can easily delete a github release and add a malicious release.

toml files supports checksum and only few tools such as zig supports it currently. It also doesn't make sense for me to ask some of these tools to support minisign.

This would also solve the scenario where randomly if I clean the tools or use a different machine my build would no longer compile since it most likely pulls in the latest version as mentioned in moonrepo/proto#248.

@prabirshrestha prabirshrestha added the enhancement New feature or request label Nov 1, 2023
@milesj
Copy link
Collaborator

milesj commented Nov 1, 2023

@prabirshrestha Starting with moon v1.16, proto plugins are fixed to a specific version, so they will never change until I bump them in another release. This will fix the drift that has happened over the past few weeks.

As for someone replacing a GitHub release with something malicious, the probability of that happening is extremely unlikely, although not impossible. Not against a lockfile, but it will require a ton of upfront work for it to be viable.

@milesj
Copy link
Collaborator

milesj commented Jun 24, 2024

Gonna close this as we're tracking it in proto. moonrepo/proto#446

@milesj milesj closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants