Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for tags in <platform|stack|type|language>.yml files #1735

Closed
svallory opened this issue Nov 26, 2024 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@svallory
Copy link

Is your feature request related to a problem? Please describe.

I would like to compose task files from granular definitions instead of using inheritance. Inheritance has served me well, but it makes it harder to reuse task definitions.

Describe the solution you'd like

I would like to be able to use tags in <platform|stack|type|language>.yml files

Describe alternatives you've considered

Trying to figure out where to place tasks so they get applied to the right projects, or using only tags.

Additional context

The mechanism seems simple to me. When a <platform|stack|type|language>.yml file has a tags attribute, those tasks are pulled into the file before task inheritance is processed

@svallory svallory added the enhancement New feature or request label Nov 26, 2024
@milesj
Copy link
Collaborator

milesj commented Nov 26, 2024

@svallory Let me see if this is even feasible. Right now tags feed into inheritance, not the other way around.

@svallory
Copy link
Author

@svallory Let me see if this is even feasible. Right now tags feed into inheritance, not the other way around.

Just to be sure I made myself clear, the goal is to allow some form of composition in the top-level task files. Tags looked to me like the way to go, but you could also do that by accepting an array in the extends field.

Now that I think of it, the extends way seems simpler.

The end goal (for me) is to be able to configure new moon repositories with moon generate commands using the templates I've been slowly gathering at moon-templates

@milesj
Copy link
Collaborator

milesj commented Jan 6, 2025

Won't support tags in those files, but did update extends to support a list in v1.31.

@milesj milesj closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants