Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practice when download URLs of a tool changed #617

Open
bjoern-reetz opened this issue Sep 25, 2024 · 3 comments
Open

Best practice when download URLs of a tool changed #617

bjoern-reetz opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bjoern-reetz
Copy link
Contributor

What version?

any

Which command?

proto install ruff

What happened?

While I was using the proto 3rd party TOML plugin for ruff I realized it did not give me the latest version. Upon investigating I realized that the URLs to download the assets changed because the maintainers dropped the "v" prefix in their git tags from version 0.5.0 on.

I am not sure if proto TOML plugins support multiple URL schemes at the same time. Obviously I could write a new/seperate proto TOML plugin for ruff versions starting from 0.5.0. What is the best practice in this case?

Trace logs?

No response

Operating system?

Linux

Architecture?

x64

@bjoern-reetz bjoern-reetz added the bug Something isn't working label Sep 25, 2024
@milesj
Copy link
Contributor

milesj commented Sep 25, 2024

@bjoern-reetz Yeah TOML kind of assumes things are deterministic. The only option right now to support variation is to build a WASM plugin.

@bjoern-reetz
Copy link
Contributor Author

Thank you for the clarification. While I already managed to succesfully build a TOML plugin for Proto myself, I currently don't feel capable of building a WASM-based Ruff plugin.

I talked to the maintainer of the original Ruff TOML plugin and he wished to keep his plugin backwards compatible. The only way I can see of making newer versions of Ruff available in Proto with TOML-based plugins is to build a new plugin while keeping the old one as-is.

I am aware that I could do this at any time without needing to bother you. I am mainly reaching out to you because off Ruffs plugin registry (both in Proto's documentation and via proto plugin search ruff).

Do you approve if I create a PR containing a replacement for the Ruff TOML plugin which only supports versions of Ruff >= 0.5.0?

@milesj
Copy link
Contributor

milesj commented Sep 30, 2024

@bjoern-reetz Yeah that seems fair. Maybe move the old ruff one into something like ruff-0.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants