From 38023b8733e6b65a1365ebac6759ae318cdfed8a Mon Sep 17 00:00:00 2001
From: Guille Polito <guillermopolito@gmail.com>
Date: Fri, 31 May 2024 11:02:20 +0200
Subject: [PATCH 1/3] Create test metamodel 9 and a variation of it to test
 model (re)generation

---
 .../FamixMetamodelGenerator.class.st          | 10 +++++
 .../FamixTest9BisGenerator.class.st           | 24 +++++++++++
 .../FamixTest9Generator.class.st              | 40 +++++++++++++++++++
 3 files changed, 74 insertions(+)
 create mode 100644 src/Famix-TestGenerators/FamixTest9BisGenerator.class.st
 create mode 100644 src/Famix-TestGenerators/FamixTest9Generator.class.st

diff --git a/src/Famix-MetamodelBuilder-Core/FamixMetamodelGenerator.class.st b/src/Famix-MetamodelBuilder-Core/FamixMetamodelGenerator.class.st
index 30b00749..bb22e8b8 100644
--- a/src/Famix-MetamodelBuilder-Core/FamixMetamodelGenerator.class.st
+++ b/src/Famix-MetamodelBuilder-Core/FamixMetamodelGenerator.class.st
@@ -58,6 +58,16 @@ FamixMetamodelGenerator class >> composedMetaModels [
 	^ self allSubclasses select: [ :mm | mm isAbstract not and: [ mm isComposed ] ]
 ]
 
+{ #category : #generation }
+FamixMetamodelGenerator class >> deleteMetaModel [
+	<script>
+	<ignoreForCoverage>
+	
+	"Remove the package that was generated by this generator.
+	This is used to cleanup existing code and testing"
+	self packageName asPackage removeFromSystem
+]
+
 { #category : #generation }
 FamixMetamodelGenerator class >> generate [
 	<script>
diff --git a/src/Famix-TestGenerators/FamixTest9BisGenerator.class.st b/src/Famix-TestGenerators/FamixTest9BisGenerator.class.st
new file mode 100644
index 00000000..75e53247
--- /dev/null
+++ b/src/Famix-TestGenerators/FamixTest9BisGenerator.class.st
@@ -0,0 +1,24 @@
+Class {
+	#name : #FamixTest9BisGenerator,
+	#superclass : #FamixTest9Generator,
+	#category : #'Famix-TestGenerators'
+}
+
+{ #category : #accessing }
+FamixTest9BisGenerator class >> packageName [
+
+	^ #'Famix-Test9-Entities'
+]
+
+{ #category : #accessing }
+FamixTest9BisGenerator class >> prefix [
+
+	^ #'FamixTest9'
+]
+
+{ #category : #definition }
+FamixTest9BisGenerator >> defineRelations [
+
+	"Here everything is the same except for the entities on the relation"
+	subclass *- superclass
+]
diff --git a/src/Famix-TestGenerators/FamixTest9Generator.class.st b/src/Famix-TestGenerators/FamixTest9Generator.class.st
new file mode 100644
index 00000000..8325d5ce
--- /dev/null
+++ b/src/Famix-TestGenerators/FamixTest9Generator.class.st
@@ -0,0 +1,40 @@
+Class {
+	#name : #FamixTest9Generator,
+	#superclass : #FamixBasicInfrastructureGenerator,
+	#instVars : [
+		'superclass',
+		'subclass'
+	],
+	#category : #'Famix-TestGenerators'
+}
+
+{ #category : #accessing }
+FamixTest9Generator class >> packageName [
+
+	^ #'Famix-Test9-Entities'
+]
+
+{ #category : #accessing }
+FamixTest9Generator class >> prefix [
+
+	^ #'FamixTest9'
+]
+
+{ #category : #definition }
+FamixTest9Generator >> defineClasses [
+
+	superclass := self builder newClassNamed: #MySuperclass.
+	subclass := self builder newClassNamed: #MySubclass
+]
+
+{ #category : #definition }
+FamixTest9Generator >> defineHierarchy [
+
+	subclass --|> superclass
+]
+
+{ #category : #definition }
+FamixTest9Generator >> defineRelations [
+
+	subclass *- subclass
+]

From 433f49a6dd51015a57c85d50b4c251ba50062a71 Mon Sep 17 00:00:00 2001
From: Guille Polito <guillermopolito@gmail.com>
Date: Fri, 31 May 2024 11:52:44 +0200
Subject: [PATCH 2/3] Add support for slot removals on pre-generated
 metamodels. Removals are performed before additions to avoid runtime
 conflicts (e.g. see Issue
 https://github.com/moosetechnology/Famix/issues/366)

---
 .../FmxClassRemoval.class.st                  |  6 ++
 .../FmxCodeChange.class.st                    |  6 ++
 .../FmxMBRealRingEnvironment.class.st         | 57 +++++++++++++------
 .../FmxMethodRemovals.class.st                |  6 ++
 .../FmxSlotRemovals.class.st                  | 47 +++++++++++++++
 5 files changed, 106 insertions(+), 16 deletions(-)
 create mode 100644 src/Famix-MetamodelBuilder-Core/FmxSlotRemovals.class.st

diff --git a/src/Famix-MetamodelBuilder-Core/FmxClassRemoval.class.st b/src/Famix-MetamodelBuilder-Core/FmxClassRemoval.class.st
index 988f68f5..67ecfc52 100644
--- a/src/Famix-MetamodelBuilder-Core/FmxClassRemoval.class.st
+++ b/src/Famix-MetamodelBuilder-Core/FmxClassRemoval.class.st
@@ -47,6 +47,12 @@ FmxClassRemoval >> classToRemove: anObject [
 	class := anObject
 ]
 
+{ #category : #testing }
+FmxClassRemoval >> isRemoval [
+
+	^ true
+]
+
 { #category : #printing }
 FmxClassRemoval >> printOn: aStream [
 
diff --git a/src/Famix-MetamodelBuilder-Core/FmxCodeChange.class.st b/src/Famix-MetamodelBuilder-Core/FmxCodeChange.class.st
index fdee04fb..ef6c46ac 100644
--- a/src/Famix-MetamodelBuilder-Core/FmxCodeChange.class.st
+++ b/src/Famix-MetamodelBuilder-Core/FmxCodeChange.class.st
@@ -28,3 +28,9 @@ FmxCodeChange class >> isAbstract [
 FmxCodeChange >> apply [
 	self subclassResponsibility
 ]
+
+{ #category : #testing }
+FmxCodeChange >> isRemoval [
+
+	^ false
+]
diff --git a/src/Famix-MetamodelBuilder-Core/FmxMBRealRingEnvironment.class.st b/src/Famix-MetamodelBuilder-Core/FmxMBRealRingEnvironment.class.st
index c76cd40a..bc131bac 100644
--- a/src/Famix-MetamodelBuilder-Core/FmxMBRealRingEnvironment.class.st
+++ b/src/Famix-MetamodelBuilder-Core/FmxMBRealRingEnvironment.class.st
@@ -9,8 +9,10 @@ Class {
 
 { #category : #accessing }
 FmxMBRealRingEnvironment >> apply [
+
 	self collectChangesToApply.
-	changesToApply do: #apply
+	changesToApply select: [ :e | e isRemoval ] thenDo: #apply.
+	changesToApply select: [ :e | e isRemoval not ] thenDo: #apply
 ]
 
 { #category : #testing }
@@ -41,25 +43,48 @@ FmxMBRealRingEnvironment >> compile: aSource in: aClass classified: aProtocol pa
 ]
 
 { #category : #installing }
-FmxMBRealRingEnvironment >> recordAdoptionOfClassDefinitionFrom: realClass to: anRGClass [
+FmxMBRealRingEnvironment >> recordAdoptionOfClassDefinitionFrom: currentClass to: anRGClassModel [
+
+	| currentCustomSlots currentCustomSlotNames modelSlotDefinitions currentGeneratedSlots modelGeneratedSlots slotRemovals |
+	(currentClass needToAdaptTo: anRGClassModel) ifFalse: [ ^ self ].
+
+	"We are updating a class installed in the system (currentClass) to a new representation defined in the model (anRGClass).
+	This has to be done in order to allow updating the class at run time"
+
+	currentGeneratedSlots := currentClass generatedSlots.
+	currentCustomSlots := currentClass localSlots copyWithoutAll:
+		                      currentGeneratedSlots.
+	currentCustomSlotNames := currentCustomSlots collect: #name.
+
+	modelGeneratedSlots := anRGClassModel slots reject: [ :each |
+		                       currentCustomSlotNames includes: each name ].
+
+	modelSlotDefinitions := (modelGeneratedSlots collect:
+		                         #definitionString) asOrderedCollection.
+	modelSlotDefinitions addAll:
+		(currentCustomSlots collect: #definitionString).
+	modelSlotDefinitions := modelSlotDefinitions sorted.
 
-	| customSlots customSlotNames slotDefinitions |
-	(realClass needToAdaptTo: anRGClass) ifFalse: [ ^ self ].
+	slotRemovals := currentGeneratedSlots reject: [ :e |
+		                modelGeneratedSlots anySatisfy: [ :current |
+			                current name = e name ] ].
 
-	customSlots := realClass localSlots copyWithoutAll: realClass generatedSlots.
-	customSlotNames := customSlots collect: #name.
-	slotDefinitions := ((anRGClass slots reject: [ :each | customSlotNames includes: each name ]) collect: #definitionString) asOrderedCollection.
-	slotDefinitions addAll: (customSlots collect: #definitionString).
-	slotDefinitions := slotDefinitions sorted.
+	slotRemovals ifNotEmpty: [
+		changesToApply add: (FmxSlotRemovals slots: slotRemovals) ].
 
 	self
-		recordClassAdditionFromClass: anRGClass
-		traits: (self traitStringFrom: realClass to: anRGClass)
-		slots: '{' , (slotDefinitions joinUsing: '. ') , '}'
-		classSlots: '{' , ((realClass class localSlots collect: #definitionString) joinUsing: ' . ') , '}'
-		sharedVariables: '{' , ((realClass classVarNames collect: [ :each | '#' , each ]) joinUsing: ' ') , '}'
-		package: realClass package name
-		tag: realClass packageTag name
+		recordClassAdditionFromClass: anRGClassModel
+		traits: (self traitStringFrom: currentClass to: anRGClassModel)
+		slots: '{' , (modelSlotDefinitions joinUsing: '. ') , '}'
+		classSlots:
+			'{' , ((currentClass class localSlots collect: #definitionString)
+				 joinUsing: ' . ') , '}'
+		sharedVariables:
+			'{'
+			, ((currentClass classVarNames collect: [ :each | '#' , each ])
+					 joinUsing: ' ') , '}'
+		package: currentClass package name
+		tag: currentClass packageTag name
 ]
 
 { #category : #installing }
diff --git a/src/Famix-MetamodelBuilder-Core/FmxMethodRemovals.class.st b/src/Famix-MetamodelBuilder-Core/FmxMethodRemovals.class.st
index 2d325db4..4a61d6b6 100644
--- a/src/Famix-MetamodelBuilder-Core/FmxMethodRemovals.class.st
+++ b/src/Famix-MetamodelBuilder-Core/FmxMethodRemovals.class.st
@@ -41,6 +41,12 @@ FmxMethodRemovals >> apply [
 	self selectors do: [ :selector | class removeSelector: selector ]
 ]
 
+{ #category : #testing }
+FmxMethodRemovals >> isRemoval [
+
+	^ true
+]
+
 { #category : #accessing }
 FmxMethodRemovals >> selectors [
 	^ selectors
diff --git a/src/Famix-MetamodelBuilder-Core/FmxSlotRemovals.class.st b/src/Famix-MetamodelBuilder-Core/FmxSlotRemovals.class.st
new file mode 100644
index 00000000..3553aa36
--- /dev/null
+++ b/src/Famix-MetamodelBuilder-Core/FmxSlotRemovals.class.st
@@ -0,0 +1,47 @@
+"
+Description
+--------------------
+
+I represent a the removal of slots from a class when updating an already generated metamodel.
+
+"
+Class {
+	#name : #FmxSlotRemovals,
+	#superclass : #FmxCodeChange,
+	#instVars : [
+		'slots'
+	],
+	#category : #'Famix-MetamodelBuilder-Core-Changes'
+}
+
+{ #category : #'as yet unclassified' }
+FmxSlotRemovals class >> slots: aCollection [
+
+	^ self new
+		  slots: aCollection;
+		  yourself
+]
+
+{ #category : #accessing }
+FmxSlotRemovals >> apply [
+
+	slots do: [ :e | e owningClass removeInstVarNamed: e name  ]
+]
+
+{ #category : #testing }
+FmxSlotRemovals >> isRemoval [
+
+	^ true
+]
+
+{ #category : #accessing }
+FmxSlotRemovals >> slots [
+
+	^ slots
+]
+
+{ #category : #accessing }
+FmxSlotRemovals >> slots: anObject [
+
+	slots := anObject
+]

From 00a7d994ee8bd65bb4e74a160c3d8fd1142bd171 Mon Sep 17 00:00:00 2001
From: Guille Polito <guillermopolito@gmail.com>
Date: Fri, 31 May 2024 14:30:31 +0200
Subject: [PATCH 3/3] Do not expect the new generator to be up to date

---
 src/Famix-TestGenerators/FamixTest9Generator.class.st | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/Famix-TestGenerators/FamixTest9Generator.class.st b/src/Famix-TestGenerators/FamixTest9Generator.class.st
index 8325d5ce..5002089a 100644
--- a/src/Famix-TestGenerators/FamixTest9Generator.class.st
+++ b/src/Famix-TestGenerators/FamixTest9Generator.class.st
@@ -20,6 +20,13 @@ FamixTest9Generator class >> prefix [
 	^ #'FamixTest9'
 ]
 
+{ #category : #testing }
+FamixTest9Generator class >> shouldBeUpToDateInLatestMoose [
+
+	"This generator is used dynamically by the tests"
+	^ false
+]
+
 { #category : #definition }
 FamixTest9Generator >> defineClasses [