#sort: on MooseGroup not working

[NicolasAnquetil]

For example on packages, it always sorts on alphabetical order

Note: #sort: changes the internal collection and I don't see why ?!?

MooseGroup >> sort: aBlock
	self entities: (self entities sorted: aBlock)

Apart from that, (self entities sorted: aBlock) works as expected

[jecisc]

#sort: changes the internal collection because #sort: should not return a new one but order itself and return itself.

I think we could improve it to ask to the internal collection to sort itself instead of creating a new one.

I tried to add some tests but for now they are passing (but at some point I tried to sort packages in an inspector and it did not work).

I'll do some more digging

[ClotildeToullec]

#sort does work.
The problem is the display in the inspector. We have a sort by name block in MiNavigationBrowser>>#initializePresenters.
This has been a choice to always show entities in the same order but hides the actual order of the inner collection.

[jecisc]

I did a PR to improve the implementation. moosetechnology/Famix#692

Now about the inspector what Clotilde said makes sense. Should we close the issue?

[NicolasAnquetil]

before closing

1. do we remove the automatic sorting in the inspector ? I would say yes because it is confusing (as was demonstrated)
2. can we fix the existing MooseGroup >> #sort: implementation ?

[jecisc]

The 2 is done already.

For the 1 I am not sure what is the best (there is the raw view for real state of the object)

[ClotildeToullec]

I think I found a solution. We could remove the automatic sorting but add the little arrows in the table, to do the sort when needed (as it is when inspecting an OrderedCollection for example)
What do you think?

[jecisc]

I like it

[ClotildeToullec]

Proposed fix here: moosetechnology/MooseIDE#1004