Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: a few fields are optional with vendors #107

Open
adamdecaf opened this issue Aug 3, 2020 · 6 comments
Open

file: a few fields are optional with vendors #107

adamdecaf opened this issue Aug 3, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@adamdecaf
Copy link
Member

What were you trying to do?
A vendor has made additional fields nullable which our library doesn't handle. We should look into supporting these fields being null to properly parse their files.

  • checks:correctionIndicator should be nullable
  • bundleControl:creditTotalIndicator should be nullable
  • cashLetterControl:creditTotalIndicator should be nullable
  • fileControl:creditTotalIndicator should be nullable

What did you expect to see?
File parsing should always work without errors on valid ICL files.

@adamdecaf adamdecaf added the bug Something isn't working label Aug 3, 2020
@atonks2
Copy link
Collaborator

atonks2 commented Nov 3, 2020

@adamdecaf do you have a sample payload (or payloads) that hit these cases?

@adamdecaf
Copy link
Member Author

Not off hand. What I wrote before was handed to me over slack IIRC.

@SaraAdineh
Copy link
Contributor

Hi, are there any updates on this issue. I'm trying to parse a valid file that can be opened via X9 Reader software but I'm getting invalid file errors. For example in Return ICL files having a settlementDate in cashLetterControl is always blank and this field is conditional according to the docs. But the parser doesn't accept this as a valid ICL file. Is there any timeline for this feature to become available?

BTW, this is a great 3rd party lib! Thank you :)

@adamdecaf
Copy link
Member Author

@SaraAdineh Thanks for the update. Do you have the spec version handy?

@SaraAdineh
Copy link
Contributor

@adamdecaf I'm not sure what the spec version is. What is that used for?

@adamdecaf
Copy link
Member Author

@SaraAdineh There are multiple versions of ICL messages in the wild/production, so it's tricky to design a parser that supports all the options. If we're able to figure out what version you (or your vendor) requires it'll help us solve your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants