fix wrong response data #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 86.81% 86.86% +0.04%
==========================================
Files 36 36
Lines 5089 5093 +4
==========================================
+ Hits 4418 4424 +6
+ Misses 437 436 -1
+ Partials 234 233 -1 |
atonks2
reviewed
Oct 19, 2023
| @@ -282,7 +282,12 @@ func deleteFile(logger log.Logger, repo ICLFileRepository) http.HandlerFunc { | |||
|
|
|||
| w.Header().Set("Content-Type", "application/json; charset=utf-8") | |||
| w.WriteHeader(http.StatusOK) | |||
| json.NewEncoder(w).Encode(`{"error": null}`) | |||
|
|
|||
| type response struct { | |||
There was a problem hiding this comment.
Will you define this as a reusable type instead of duplicating it inside each method? Something like type ErrorResponse struct.
atonks2
reviewed
Oct 19, 2023
| if err != nil { | ||
| fmt.Printf("Error decoding '%X' as EBCDIC: %v\n", lineIn, err) | ||
| } | ||
| lineOut, _ = encoding.EBCDIC.NewDecoder().String(lineIn) |
There was a problem hiding this comment.
This has been fixed on master. Will you rebase or merge master into your branch and accept that version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#316