Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: accept image data as multipart request #99

Open
adamdecaf opened this issue Jul 24, 2020 · 2 comments
Open

server: accept image data as multipart request #99

adamdecaf opened this issue Jul 24, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@adamdecaf
Copy link
Member

adamdecaf commented Jul 24, 2020

Related to #86 we should also accept image data as mult-part form params which can be replaced in the JSON representation. Bundling base64'd image data blobs in JSON can be a pain. The previous format would still be accepted.

I'm thinking that ImageViewData's ImageData could have identifiers related to the form blocks.

The block containing JSON would be named file.

{
  // ... 
  "imageViewData": {
    "imageData": ":checkOne:"
  },
  // ... 
}

Then a second block/boundary called checkOne with the encoded image data. The HTTP server would replace that data directly into the ImageViewData struct. We could try base64 decoding this data.

@adamdecaf adamdecaf added enhancement New feature or request help wanted Extra attention is needed labels Jul 24, 2020
@InfernoJJ
Copy link
Member

Lets get this to accept multi-part form encoding as well as base64 in json.

@adamdecaf
Copy link
Member Author

I made #100 for base64 decoding. As part of this change we'd accept bae64'd data in the form boundary as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants