Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

upload: support different configurations for organizations #600

Open
adamdecaf opened this issue Oct 16, 2020 · 1 comment
Open

upload: support different configurations for organizations #600

adamdecaf opened this issue Oct 16, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@adamdecaf
Copy link
Member

PayGate Version: v0.9.0-dev

With a multi-organization setup in PayGate we should support an upload.Agent config for each organization. This involves an array of possible configurations and then a setting on each organization for which to use.

upload:
  ftpConfigs:
    - id: "test" 
      hostname: <string>
      # ... 
      inboundPath: <string> # moved from ODFI config
  sftpConfigs:
    - id: "my-bank"
      hostname: <string>
      # ... 
      inboundPath: <string> # moved from ODFI config 

The inboundPath, outboundPath, returnPath configurations would need to move from ODFI over to each upload.Agent as they could be different for each server. The existing FTP/SFTP configs would move out from ODFI also.

This value would be stored as part of the organization_configuration table we're creating. Perhaps on a column like upload_agent_id and a value like sftp:my-bank? When that value can't match to a configured ftp/sftp config we'd need to error.

I don't think GET/PUT /configuration/transfers should support this value - it's internal for operators and we don't want a client changing it. If we need to support changing it in the future we can include it in the endpoint.

This change allows org1 to use ftp:test while org2 can use sftp:my-bank as different upload configs. Also with #596 we're going to be including the hostname for each server as that'll allow us to determine where files/transfers went.

@adamdecaf adamdecaf added the enhancement New feature or request label Oct 16, 2020
@atonks2
Copy link
Contributor

atonks2 commented Oct 16, 2020

This sounds like a good proposal to me. The only thing I'd add is that it would be useful to include the upload agent ID in upload/download notifications, in addition to the hostname added in #596.

@jmbrown412 jmbrown412 self-assigned this Oct 30, 2020
@jmbrown412 jmbrown412 removed their assignment Oct 30, 2020
@jmbrown412 jmbrown412 self-assigned this Oct 30, 2020
@adamdecaf adamdecaf added this to the v0.10.0 milestone Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants