Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Rationals for clock valuations #90

Open
morxa opened this issue May 11, 2021 · 1 comment
Open

Consider using Rationals for clock valuations #90

morxa opened this issue May 11, 2021 · 1 comment

Comments

@morxa
Copy link
Owner

morxa commented May 11, 2021

We currently use double for clock valuations, which already caused some bugs, e.g., #88.

We might want to use Rationals altogether. We should check again whether this would make sense.

@modass
Copy link
Collaborator

modass commented Jan 16, 2023

I believe this makes perfect sense, but we have to be aware that operations on rationals are about 200x slower (from experience, using libgmpxx).

Another option is, once we have fixed the granularity to use integers as representants (i.e., decide on a common divisor and only argue about and store the numerator) - this way we get the best of both worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants