Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming Simulator errors with default parameters #831

Closed
dneup opened this issue Nov 20, 2024 · 2 comments · Fixed by #840
Closed

Streaming Simulator errors with default parameters #831

dneup opened this issue Nov 20, 2024 · 2 comments · Fixed by #840
Labels
bug Something isn't working

Comments

@dneup
Copy link

dneup commented Nov 20, 2024 •
edited
Loading

I installed the Streaming Simulator and when I tried to run it I got the following error.

To reproduce

  1. Start the Streaming Simulator.
  2. Press "Simulate Run" with the default values.

Produces the error:

AttributeError: 'SimulationDataset' object has no attribute 'epoch_seed_change'
Traceback:
File "/my/project/.venv/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/exec_code.py", line 88, in exec_func_with_error_handling
    result = func()
File "/my/project/.venv/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 579, in code_to_exec
    exec(code, module.__dict__)
File "/my/project/.venv/lib/python3.10/site-packages/simulation/interfaces/sim_ui.py", line 411, in <module>
    submit_jobs(shuffle_quality, dataset, time_per_sample, node_internet_bandwidth,
File "/my/project/.venv/lib/python3.10/site-packages/simulation/interfaces/sim_ui.py", line 114, in submit_jobs
    for output in gen_sim:
File "/my/project/.venv/lib/python3.10/site-packages/simulation/interfaces/../core/main.py", line 109, in simulate
    samples_per_node = dataset.get_samples_per_node(epoch, 0)
File "/my/project/.venv/lib/python3.10/site-packages/simulation/interfaces/../core/sim_dataset.py", line 367, in get_samples_per_node
    partition = generate_work(self.batching_method, self, self.world, epoch, sample_in_epoch)
File "/my/project/.venv/lib/python3.10/site-packages/streaming/base/batching/__init__.py", line 45, in generate_work
    return get(dataset, world, epoch, sample_in_epoch)
File "/my/project/.venv/lib/python3.10/site-packages/streaming/base/batching/random.py", line 49, in generate_work_random_batching
    shuffle_units, small_per_big = dataset.resample_streams(epoch)
File "/my/project/.venv/lib/python3.10/site-packages/streaming/base/dataset.py", line 882, in resample_streams
    epoch, self.epoch_seed_change)

Expected behavior

The Streaming Simulator produces a simulation.

Will the Streaming Simulator be maintained actively?
@dneup dneup added the bug Something isn't working label Nov 20, 2024
@dneup dneup changed the title Streaming Simulator errors with default paramters Streaming Simulator errors with default parameters Nov 20, 2024
@karan6181
Copy link
Collaborator

@snarayan21 Maybe a minor bug fix due to a recent fix in the codebase?

@snarayan21
Copy link
Collaborator

snarayan21 commented Nov 21, 2024 •
edited
Loading

Oh yep, seems like it. Will address soon @karan6181

Thanks for flagging @dneup !

@srstevenson srstevenson mentioned this issue Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set epoch_seed_change attribute on SimulationDataset srstevenson/streaming
3 participants
@karan6181 @snarayan21 @dneup