Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guava Dependency #37

Open
jonknight73 opened this issue Feb 28, 2020 · 1 comment
Open

Remove Guava Dependency #37

jonknight73 opened this issue Feb 28, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jonknight73
Copy link
Contributor

Currently we are importing the Guava library for a single line of code in P2PResolvedService.java:

    mInetAddress =  InetAddresses.forString((String) map.get(P2PService.HOST_LABEL));

It would be nice to find a lighter-weight implementation.

This line is converted the string host to an InetAddress version. The standard version tends to try to use a DNS lookup which is not appropriate for WiFi Direct.
@jonknight73 jonknight73 added the enhancement New feature or request label Feb 28, 2020
@jonknight73
Copy link
Contributor Author

Linter output:
'com.google.common.net.InetAddresses' is marked unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonknight73