Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy protocol v2 support, IPv6 support #33

Closed
wants to merge 22 commits into from

Conversation

gugu
Copy link

@gugu gugu commented Dec 31, 2020

  1. Fixes Proxy protocol version 2 #23 and fixes proxy protcol v1 or v2 #28 for proxy protocol v2
  2. Uses proxy-protocol-v2 module instead of regex
  3. Removed dependency on findhit-util by using native node functions
  4. Remove the support of node.js < 10

@gugu
Copy link
Author

gugu commented Jan 3, 2021

@cusspvz can you please review this PR?

@gugu
Copy link
Author

gugu commented Jan 8, 2021

I think there are too many changes for PR, I'll do a fork

@gugu gugu closed this Jan 8, 2021
@cusspvz
Copy link
Member

cusspvz commented Jan 8, 2021

Hey @gugu,

first of all, thank you so much for contributing to this project. Right now I've still a lot of stuff on my plate, so I have this PR open on my computer for a while. I'm really interested in merging your contribution but I have to review and test it. I'm going to reopen this, but in case you need this upfront, I'd advise you to create your own fork and use it directly until we get this merged.

Thank you, looking forward to merging this and sorry for letting you in the dark!

@gugu gugu reopened this Jan 8, 2021
@gugu gugu marked this pull request as draft January 8, 2021 14:51
@gugu
Copy link
Author

gugu commented Jan 8, 2021

Let's keep this in draft state (now it has a major rewrite to support http2 and bugfix when socket.setTimeout() did not work on proxied server)

When you review this PR, I'll remove @short.io attribution from README and package.json so it would be possible to merge it

@gugu gugu closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy protcol v1 or v2 Proxy protocol version 2
2 participants