aiofile writing binary file .wav on windows issue

[wood-j]

Hello, I am using it to writing an wav file from iternet async with aiohttp. It works fine on linux, but downloaded audio sounds weird on windows.

    async def download_audio(self, task_line: TaskLine):
        url = f'{self.base_url}{task_line.raw_data_file_path}'
        logger.debug(url)
        async with aiohttp.ClientSession(cookie_jar=self._cookie_jar) as session:
            async with session.get(url=url) as resp:
                assert resp.status == 200, f'request error status code: {resp.status}'
                path = task_line.audio_file_path()
                dir, _ = os.path.split(path)
                if not os.path.exists(dir):
                    os.mkdir(dir)
                async with AIOFile(path, 'wb') as f:
                    await f.write(await resp.read())

When I change write to file code with internal open method, the audio file download turn out be fine.

    async def download_audio(self, task_line: TaskLine):
        url = f'{self.base_url}{task_line.raw_data_file_path}'
        logger.debug(url)
        async with aiohttp.ClientSession(cookie_jar=self._cookie_jar) as session:
            async with session.get(url=url) as resp:
                assert resp.status == 200, f'request error status code: {resp.status}'
                path = task_line.audio_file_path()
                dir, _ = os.path.split(path)
                if not os.path.exists(dir):
                    os.mkdir(dir)
                # async with AIOFile(path, 'wb') as f:
                #     await f.write(await resp.read())
                with open(path, 'wb') as f:
                    f.write(await resp.read())

Downloaded audio file info:
AIOFile:

open:

By the way, I am using manjaro18 linux system and windows10 ltsb2016 and both python3 latest version 3.7.3

aiofile        1.5.2
aiohttp        3.5.4

[wood-j]

Here is a short test code:

import os
import aiohttp
import asyncio
from aiofile import AIOFile


async def download1(url: str, path: str):
    async with aiohttp.ClientSession() as session:
        async with session.get(url=url) as resp:
            assert resp.status == 200, f'request error status code: {resp.status}'
            async with AIOFile(path, 'wb') as f:
                await f.write(await resp.read())


async def download2(url: str, path: str):
    async with aiohttp.ClientSession() as session:
        async with session.get(url=url) as resp:
            assert resp.status == 200, f'request error status code: {resp.status}'
            with open(path, 'wb') as f:
                f.write(await resp.read())


if __name__ == '__main__':
    url = 'http://light.ucme.top/files/35eaecb0-60ba-11e9-8d8f-8cec4b573ab2.tts.wav'
    asyncio.run(download1(url, '1.wav'))
    asyncio.run(download2(url, '2.wav'))

[lemurchik]

There is a general problem with binary files write on Windows

[lemurchik]

#25

[dimaqq]

Now that #19 is done via #25, perhaps this issue too is resolved?
@wood-j would you care to test, please 🙏🏼

[wood-j]

Now that #19 is done via #25, perhaps this issue too is resolved? @wood-j would you care to test, please 🙏🏼

Tested ok on my windows env, thanks for the fix @dimaqq

[dimaqq]

It was not my fix, but I'm happy to help even by pointing things out :)