Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergeMapConcurrently flow type has reversed parameters #289

Closed
briancavalier opened this issue Jun 17, 2019 · 0 comments · Fixed by #291
Closed

mergeMapConcurrently flow type has reversed parameters #289

briancavalier opened this issue Jun 17, 2019 · 0 comments · Fixed by #291
Assignees

Comments

@briancavalier
Copy link
Member

The flow type of mergeMapConcurrently list the initial parameters as concurrency, f, but the implementation says f, concurrency.

See also #288, which adds the missing TypeScript defs with the correct parameter order (matching the implementation).

For 1.x, let's fix the flow type.

It may be nice to consider a future (breaking) change to reverse the parameters in the implementation, since partially applying concurrency would result in the same type as other higher order combinators, like chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant