Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning of unsupported TypeScript version #528

Open
Frikki opened this issue Oct 3, 2020 · 3 comments
Open

Warning of unsupported TypeScript version #528

Frikki opened this issue Oct 3, 2020 · 3 comments

Comments

@Frikki
Copy link
Member

Frikki commented Oct 3, 2020

@most/core version: 1.6.1

Steps To Reproduce

  1. Install Local Javascript Dependencies
npm install
  1. Run Tests
npm test

The Current Behavior

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.2.1 <3.6.0

YOUR TYPESCRIPT VERSION: 3.9.7

Please only submit bug reports when using the officially supported version.

=============

The Expected Behavior

No warnings.

Suggestion

Three options:

A. Upgrade the @typescript-eslint/* packages to the latest versions, as the version range of TypeScript currently supported by their parser is >=3.3.1 <4.1.0.

B. Disable warning by configuring parserOptions.

C. Pin TypeScript dependency to <3.6.0.

In @most/core package.json, the related packages are pinned to version ^1.1.0, while several major releases have been issued since. E.g., the current version of @typescript-eslint/eslint-parser is 4.3.0. If we go for Option A, we should consider unpinning these packages in the dependencies, i.e., set their values to ^4.0.0.

Cast Your Vote



@TylorS
Copy link
Member

TylorS commented Oct 7, 2020

My vote would definitely be for option 1

@briancavalier
Copy link
Member

Same, 1 seems like the way to go. Let's hope it doesn't turn into a huge ball of dependency string.

@Frikki
Copy link
Member Author

Frikki commented Oct 7, 2020

@briancavalier I expect it to, but hopefully not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants