Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason why at(time, val) is not curried? #676

Open
semmel opened this issue Feb 17, 2024 · 3 comments · Fixed by #677
Open

Is there a reason why at(time, val) is not curried? #676

semmel opened this issue Feb 17, 2024 · 3 comments · Fixed by #677
Labels
2.0 Changes requiring a major version bump 1.x -> 2.0

Comments

@semmel
Copy link
Contributor

semmel commented Feb 17, 2024

Apart from runEffects, at seems to be the only (n>1)-ary function which is not auto-curried.

I find that surprising.
Is there a reason for it?

@briancavalier
Copy link
Member

Hey, @semmel. I don't think there's a reason--probably just an oversight. Sorry for the surprise. We'd happily accept a PR to curry it 😄

@briancavalier briancavalier added the 2.0 Changes requiring a major version bump 1.x -> 2.0 label Mar 8, 2024
@briancavalier briancavalier reopened this Mar 8, 2024
@TylorS
Copy link
Member

TylorS commented Mar 8, 2024

It may be a good idea to start brainstorming what a 2.0 might look like now that we have something deferred there. Maybe we should create an issue dedicated to it so we can discuss our ideas?

Some off-the-cuff ideas I have:

  • Utilize the ES native Disposable type, pretty minor change, but breaking
  • Add support for asynchronous dispose, ideally with AsyncDisposable ES interface, fairly large change, but I have a number of usecases which rely on this behavior now, mostly undoing failures.
  • Add additional type parameters, could be one or both
    • E parameter to explicitly track error types
    • R parameter to allow tracking the context a Stream is running within

@TylorS
Copy link
Member

TylorS commented Mar 9, 2024

I created a discussion so we can have some amount of threading and such for conversation - #680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 Changes requiring a major version bump 1.x -> 2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants