Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying git tags #2

Open
urbanslug opened this issue Mar 19, 2018 · 3 comments
Open

Deploying git tags #2

urbanslug opened this issue Mar 19, 2018 · 3 comments

Comments

@urbanslug
Copy link

One can't deploy git tags because of the requirement for a var ECS_CLUSTER_BRANCH_NAME

There also isn't a way to just let one set CLUSTER because it's overriden here https://github.com/motleyagency/travis-ecs-deploy/blob/master/lib/ecs-deploy#L92 and set to false.

There should be a way for users to just pass --service-name and --cluster without the need to go through travis-ecs-deploy

@petetnt
Copy link
Member

petetnt commented Apr 13, 2018

@urbanslug hi! Sorry for the late reply.

That sounds great! The ecs-deploy is vendored from https://github.com/silinternational/ecs-deploy/blob/develop/ecs-deploy (IIRC), so it might make sense to make the changes there first.

@urbanslug
Copy link
Author

@petetnt Sorry for the late reply too.

Not sure if I'll have time to put into this because I am migrating services from ECS to kubernetes. Feel free to close the issue.

@petetnt
Copy link
Member

petetnt commented Apr 23, 2018

@urbanslug no problem! I'll keep the issue open as it definitely something that would be really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants