Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up clang-tidy + test config changes #2205

Open
henningkayser opened this issue May 25, 2023 · 3 comments
Open

Speed-up clang-tidy + test config changes #2205

henningkayser opened this issue May 25, 2023 · 3 comments
Labels
enhancement New feature or request infrastructure persistent Allows issues to remain open without automatic stalling and closing.

Comments

@henningkayser
Copy link
Member

henningkayser commented May 25, 2023

There are two somewhat major complaints around how we do clang-tidy testing:

  1. We are missing clang-tidy fixes when changing the config, since we are only testing diffs
  2. We are only testing diffs because full checks are horribly slow (2h32m on a recent run)

There supposedly is a low-hanging fruit that improves the situation, this industrial_ci PR has been around for a while and speeds up runtime considerably (tested internally).
@EzraBrooks has also suggested just using run_clang_tidy.py which would be just as easy, probably even reducing complexity of the CI config.

@henningkayser henningkayser added the enhancement New feature or request label May 25, 2023
@130s
Copy link
Contributor

130s commented May 25, 2023

There supposedly is a low-hanging fruit that improves the situation, this ros-industrial/industrial_ci#798 has been around for a while and speeds up runtime considerably (tested internally).

Oops, that's a shame (as one of the original authors). I'll look.

@github-actions
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Jul 10, 2023
@EzraBrooks
Copy link
Member

this is a really aggressive stale bot

@tylerjw tylerjw added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

No branches or pull requests

4 participants