Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve how to pin aptos revs in Cargo.toml for testing the bridge #862

Open
andygolay opened this issue Nov 17, 2024 · 1 comment
Open
Assignees

Comments

@andygolay
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. removes EIP-55 checksum checks in Move modules and
  2. uses event handles for events, to align with how the bridge relayer processes events.

PR 87 was rejected, on the grounds that removing EIP-55 checks would reduce security. While I disagree with that and opened an issue proposing removal of EIP-55 checksum checks from Move modules, a practical matter remains, of how to continue to develop the bridge against rev d9859a.

The movement repository main branch continues to have aptos-core revs bumped to stay on the movement branch of the aptos-core repository.

So this leaves us with the options of

  1. Creating a feature branch for bridge development. This has been shown to be impractical in the past.
  2. Modifying the bridge code so it works against the movement branch of our aptos-core fork.
  3. Other alternatives?

Describe the solution you'd like

  • Discuss which of the above solutions, or other alternatives, would make sense so that we can continue to develop the bridge in a sustainable manner.

  • The discussion should be led by the Product team (cc @rolandoesparza) to help make decisions avoid endless debate.

@0xmovses
Copy link
Contributor

0xmovses commented Nov 17, 2024

Simple the reviewers @andyjsbell & @franck44 must approve the PR instead of rejecting. It's that or feature branch. We are already using this rejected branch in prod, so the approval is more symbolic than effective at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants