You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We were using this rev of aptos-core for aptos dependencies in the movement repository to test agains. Associated with PR Suzuka Docker Compose Stack #87, the rev:
removes EIP-55 checksum checks in Move modules and
uses event handles for events, to align with how the bridge relayer processes events.
PR 87 was rejected, on the grounds that removing EIP-55 checks would reduce security. While I disagree with that and opened an issue proposing removal of EIP-55 checksum checks from Move modules, a practical matter remains, of how to continue to develop the bridge against rev d9859a.
The movement repository main branch continues to have aptos-core revs bumped to stay on the movement branch of the aptos-core repository.
So this leaves us with the options of
Creating a feature branch for bridge development. This has been shown to be impractical in the past.
Modifying the bridge code so it works against the movement branch of our aptos-core fork.
Other alternatives?
Describe the solution you'd like
Discuss which of the above solutions, or other alternatives, would make sense so that we can continue to develop the bridge in a sustainable manner.
The discussion should be led by the Product team (cc @rolandoesparza) to help make decisions avoid endless debate.
The text was updated successfully, but these errors were encountered:
Simple the reviewers @andyjsbell & @franck44 must approve the PR instead of rejecting. It's that or feature branch. We are already using this rejected branch in prod, so the approval is more symbolic than effective at this point.
Is your feature request related to a problem? Please describe.
aptos-core
for aptos dependencies in themovement
repository to test agains. Associated with PR Suzuka Docker Compose Stack #87, the rev:PR 87 was rejected, on the grounds that removing EIP-55 checks would reduce security. While I disagree with that and opened an issue proposing removal of EIP-55 checksum checks from Move modules, a practical matter remains, of how to continue to develop the bridge against rev
d9859a
.The
movement
repositorymain
branch continues to haveaptos-core
revs bumped to stay on themovement
branch of theaptos-core
repository.So this leaves us with the options of
movement
branch of ouraptos-core
fork.Describe the solution you'd like
Discuss which of the above solutions, or other alternatives, would make sense so that we can continue to develop the bridge in a sustainable manner.
The discussion should be led by the Product team (cc @rolandoesparza) to help make decisions avoid endless debate.
The text was updated successfully, but these errors were encountered: