Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching results for mozilla.org looks the same for both en-GB and the locale #256

Open
TheoChevalier opened this issue May 20, 2014 · 4 comments

Comments

@TheoChevalier
Copy link
Member

In this query for instance, I assume that for
'Matching results for Firefox OS in fr", we should only have strings with "Firefox OS" (that's a whole word query)

http://transvision-beta.mozfr.org/?recherche=Firefox+OS&repo=mozilla_org&sourcelocale=en-GB&locale=fr&search_type=strings&whole_word=whole_word

@pascalchevrel
Copy link
Member

one thing I notice is that the nbsp shouldn't be escaped

@pascalchevrel
Copy link
Member

So, there are 2 issues, one is that we are a bit too agressive on escaping lang files and we should not escape html entities like &nbsps, the second is that Firefox OS with a non breakable space doesn't match Firefox OS with a normal space. I have a fix for the extraction issue, I need to think for the second one.

@pascalchevrel
Copy link
Member

Théo, I don't have a solution to make strings containing a nbsp match strings with a non breaking space, are the other improvements in my referenced branch enough to make it more usable?

@TheoChevalier
Copy link
Member Author

Highlighting Firefox OS when we search for FirefoxOS looks good to me, it's visually easier to catch the strings we are looking for.
Thanks Pascal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants