Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the webhook, we should run setup.sh only for prod instances #759

Open
TheoChevalier opened this issue Jul 2, 2016 · 2 comments
Open
Labels

Comments

@TheoChevalier
Copy link
Member

Well, this one is funny :) I’ve set up a dev instance on my VPS, and setup a webhook on a custom branch. Every time I push to my branch, my 10GB vps tries cloning the 30+GB hg repos [1], throws that stuff at the root of the git repo, and I start crying.

[1] Because we’re running setup.sh https://github.com/mozfr/transvision/blob/master/web/github_hook.php#L67 instead of setup-dev.sh

For your enjoyment, the mess it’s creating:
capture d ecran 2016-07-02 a 19 15 19

@flodolo
Copy link
Collaborator

flodolo commented Jul 4, 2016

Not completely sure how much sense it makes to setup a webhook on a non-production installation, but I guess it wouldn't be a problem to add a check.

@TheoChevalier
Copy link
Member Author

Me working a redesign experiment and being too lazy to git pull on ssh every time I push a commit would be a use case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants