Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pontoon: move search and filter content to workspace page #249

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Pontoon: move search and filter content to workspace page #249

merged 9 commits into from
Sep 20, 2024

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented Sep 20, 2024

Fixes #246

@flodolo flodolo requested a review from a team as a code owner September 20, 2024 07:58
@flodolo flodolo removed the request for review from a team September 20, 2024 07:58
mathjazz
mathjazz approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work!

I wish I've said it earlier, so non-blocking: I was thinking that the filename should reflect this is a translation workspace/UI, so I'd rather call it translation_workspace.md.

@flodolo
Copy link
Contributor Author

flodolo commented Sep 20, 2024

Thanks, I'll need to figure out the rebase here, looks narly.

@bcolsson
Copy link
Contributor

@flodolo - wasn't sure how to point them out in github so found a couple old references and fixed them (sorry for noise on noticing small issues after committing)

@flodolo flodolo merged commit cb9d898 into main Sep 20, 2024
2 checks passed
@flodolo flodolo deleted the issue246 branch September 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcolsson bcolsson bcolsson approved these changes

@mathjazz mathjazz mathjazz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pontoon docs: Move Search and filters under Translation workspace
3 participants
@flodolo @bcolsson @mathjazz