Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXIOS-715 ⁃ Fix #4833 - Use Firefox as Safari blocker just like Focus app #5095

Closed

Conversation

ezraberch
Copy link
Contributor

@ezraberch ezraberch commented Jun 6, 2019

This PR adds a Safari Content Blocker app extension, based on the existing one in focus-ios. It uses the same tracking lists which the main app uses.

The extension will respect the strictness setting (Basic/Strict) in Settings -> Tracking Protection. It will not, however, respect the main tracking protection toggle, as this would be redundant with the enable/disable toggle in System Settings -> Safari -> Content Blockers.

┆Issue is synchronized with this Jira Task

@dnarcese dnarcese linked an issue Jun 3, 2020 that may be closed by this pull request
@garvankeeley garvankeeley changed the base branch from master to main June 29, 2020 19:17
@data-sync-user data-sync-user changed the title Fix #4833 - Use Firefox as Safari blocker just like Focus app FXIOS-715 ⁃ Fix #4833 - Use Firefox as Safari blocker just like Focus app Aug 6, 2020
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

This pull request has conflicts when rebasing. Could you fix it @ezraberch?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again .

@dnarcese dnarcese added the 2 Story size label May 5, 2021
@dnarcese
Copy link
Contributor

dnarcese commented May 5, 2021

Closing this for now as it is a P3 issue and will take time to fix the merge conflicts.
@ezraberch If you are still interested, feel free to start a new PR with the changes, or fix the merge conflicts here! Thanks for your contribution.

@dnarcese dnarcese closed this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Story size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Firefox as Safari blocker just like Focus app
2 participants