Extract middleware unit tests

[data-sync-user]

Refactor middleware tests into unit and integration test layers to clearly delineate test responsibilities

• Tests using the FAST API TestClient and responsible for verifying system interactions as a group, can be classified as integration tests
• Tests checking logical operations within middleware modules can be classified as unit tests

Example
https://github.com/mozilla-services/merino-py/pull/74

Acceptance Criteria

• The following modules are evaluated and tests refactored to unit or integration layers if appropriate:
  • featureflags.py (Tests found in tests\integration\api\v1\suggest\test_suggest.py)
  • metrics.py (Tests found in tests\integration\api\v1\suggest\test_metrics.py)
  • logging.py (Tests found in tests\integration\api\v1\suggest\test_suggest.py & tests\integration\api\test_heartbeat.py)
  • user_agent.py (Tests found in tests\integration\api\v1\suggest\test_user_agent.py)
• Integration test module names are updated to follow the endpoint naming convention
• Documentation is updated to include changes in structure or fixture

┆Issue is synchronized with this Jira Task
┆Epic: Add integration test layer to merino-py

[data-sync-user]

➤ Katrina Anderson commented:

Update (2022/11/08)

• Update acceptance criteria to include more specifics
• Refactored tests for UserAgent & FeatureFlags modules
• Update integration test module names
• Update documentation
• Create draft pull requesthttps://github.com/[CONSVC-2063] test: extract middleware unit tests #106 ( https://github.com/mozilla-services/merino-py/pull/106|smart-link )
  • Asked for behaviour verification in comments

[data-sync-user]

➤ Katrina Anderson commented:

Update (2022/11/09)

• Refactor tests for LoggingMiddleware and update draft PR

[data-sync-user]

➤ Katrina Anderson commented:

Update (2022/11/10)

• Refactored LoggingMiddleware logic into a utility for better testability

[data-sync-user]

➤ Katrina Anderson commented:

Update (2022/11/14)

• Refactored MetricsMiddleware integration tests into endpoint modules
• Added unit test module