Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Reviewer tools: Support attaching a zip file to a review #14999

Open
1 task
wagnerand opened this issue Sep 3, 2024 · 3 comments · May be fixed by mozilla/addons-server#22670
Open
1 task

[Task]: Reviewer tools: Support attaching a zip file to a review #14999

wagnerand opened this issue Sep 3, 2024 · 3 comments · May be fixed by mozilla/addons-server#22670
Assignees
@chrstinalin
Labels
repository:addons-server Issue relating to addons-server

Comments

@wagnerand
Copy link
Member

wagnerand commented Sep 3, 2024 •
edited by data-sync-user
Loading

Description

To reduce reviewer workload by doing the same task of building an artifact for a developer to check repeatedly and to eliminate the dependency on a third-party service, the reviewer tools should support adding a zip attachment to at least rejections and reviewer replies. If it's not too much additional effort, ideally it should be supported for all actions.

Acceptance Criteria

Milestones/checkpoints
Beta Give feedback

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.
  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task
@wagnerand wagnerand added needs:info repository:addons-server Issue relating to addons-server labels Sep 3, 2024
@wagnerand wagnerand changed the title [Task]: Reviewer tools. Support attaching a zip file to a review [Task]: Reviewer tools: Support attaching a zip file to a review Sep 3, 2024
@chrstinalin chrstinalin self-assigned this Sep 5, 2024
@diox
Copy link
Member

diox commented Sep 10, 2024

Let's start with a 100 MB file limit to begin with and see how it goes.

@diox
Copy link
Member

diox commented Sep 10, 2024

Note: zip files should also go through SafeZip like all our zip files.

@diox diox removed the needs:info label Sep 10, 2024
@wagnerand
Copy link
Member Author

Let's do 200MB. Several dozen versions submitted just this year have XPI files larger than 100MB and at least one of them is Notable.

@chrstinalin chrstinalin linked a pull request Sep 16, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrstinalin chrstinalin

Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Zip Files to be Uploaded as Attachment chrstinalin/addons-server
3 participants
@diox @wagnerand @chrstinalin