Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Mention max allowable filesize on developer hub when uploading a new version #14835

Open
1 task
abyrne-moz opened this issue Jun 7, 2024 · 5 comments · May be fixed by mozilla/addons-server#22691
Open
1 task

[Task]: Mention max allowable filesize on developer hub when uploading a new version #14835

abyrne-moz opened this issue Jun 7, 2024 · 5 comments · May be fixed by mozilla/addons-server#22691
Labels
component:developer_hub contrib:good_first_bug repository:addons-server Issue relating to addons-server

Comments

@abyrne-moz
Copy link

abyrne-moz commented Jun 7, 2024 •
edited by data-sync-user
Loading

Description

The maximum file size supported in the developer hub for submitting an add-on is 200MB, but we do not mention this on the file submission page. This task is to update the page to mention this limit by appending this text to the upload page.

The maximum file size accepted is 200 MB. If your add-on is larger than 200 MB, it will fail validation.

image

Acceptance Criteria

Acceptance Criteria
Beta Give feedback

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.

┆Issue is synchronized with this Jira Task
@abyrne-moz
Copy link
Author

This text should also be added to the Source Code submission upload page.

The maximum file size accepted is 200MB.

image

@diox diox removed the needs:info label Jun 13, 2024
@diox
Copy link
Member

diox commented Jun 13, 2024

Technically addons-server limits are more complex than that but it's not a bad limit to advertise.

@diox diox added repository:addons-server Issue relating to addons-server and removed repository:addons-frontend Issue relating to addons-frontend labels Aug 5, 2024
@diox diox mentioned this issue Sep 20, 2024
Open
3 tasks
@diox
Copy link
Member

diox commented Sep 20, 2024

Added bonus:

Use some JS to trigger size detection when the file input is changed. In that, call setCustomValidity() with a custom message if the size is over the limit, and otherwise call it to reset it to '' if valid. The user would need to change the file if they want to continue.

If going that route though, they'd probably also need to be able to clear the input completely to start over.

@chrstinalin chrstinalin linked a pull request Sep 20, 2024 that will close this issue
Open
3 tasks
@chrstinalin
Copy link

@diox That sort of sounds like its own separate issue? Or at least seems odd to include alongside this one

@diox
Copy link
Member

diox commented Sep 20, 2024

Maybe, yes. We can file another issue, doesn't have to be bundled into that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:developer_hub contrib:good_first_bug repository:addons-server Issue relating to addons-server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention max allowable filesize on DevHub when uploading versions/sources chrstinalin/addons-server
3 participants
@diox @chrstinalin @abyrne-moz